[Thread Prev][Thread Next][Index]

Re: ParseLex 2.15



Andrew,

An extremely late thank you for this fix. We're putting the finishing touches on LAS 6.5, which we hope to release in January, and I'm going through email trying to catch all the code fixes sent in by our illustrious LAS users.

I'm sure that your effort in reporting this fix will save others many hours of frustration and I encourage anybody else who has fixed bugs while installing LAS to send in those fixes now so they can get into the next release.

Thanks again and best wishes for a happy holiday season.


-- Jon


Chase, Andrew wrote:

I had some troubles getting the ParseLex package installed and wanted to point out to little errors I found in the ParseLex-2.15 available from cpan. The package from cpan is assumably the same as what is included in the LAS 6.4.1.0 installation that I'm working from, but went ahead and grabbed the source from CPAN to make sure I wasn't running into problems with the LAS distrobution of the package.

I've found two small errors in the ParseLex-2.15 package that were preventing me from installing it on my Fedora 3 linux machine. I'm assuming that they would affect other platforms as well, but I haven't seen any talk of it.
In $ParseLexHome/lib/Parse/Template.pm there's two errors. The first is on line 1, 'use strict' is missing a simi colon.
The next is on line 501, the variable $expr needs to be declared as a new variable by adding 'my' in front of it.
broken: $expr = $1;
fixed : my $expr = $1;
For me, that moved the make test from 0% passing to 85.71% passing.
Maybe the older versions of the perl interpreter were ignoring these little errors and the new one doesn't? Who knows.

The other error appears in t/test4.t and it looks like it is being caused by a change in the perl output from whatever version of perl the test was created for to the version I'm running (perl 5.8.5). The details are the same, but the formatting is different.

I read a bit about a patch for ParseLex-2.15 included in LAS, maybe I'm duplicating those efforts?

Cheers,
Andrew

Software Engineer
MBARI




[Thread Prev][Thread Next][Index]

Dept of Commerce / NOAA / OAR / PMEL / TMAP
Contact Us | Privacy Policy | Disclaimer | Accessibility Statement